Able to delete task and device from GUI, missed the call to the server before #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mads256h
approved these changes
May 9, 2024
Puvikaran2001
force-pushed
the
142-app-device-overview-page-remove-device-button-not-sending-request-to-backend
branch
from
929725f
to
04141c1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
=======================================
Coverage 85.74% 85.74%
=======================================
Files 20 20
Lines 2441 2441
=======================================
Hits 2093 2093
Misses 348 348 ☔ View full report in Codecov by Sentry. |
Puvikaran2001
force-pushed
the
142-app-device-overview-page-remove-device-button-not-sending-request-to-backend
branch
from
307e9b5
to
60af694
Compare
Darkros1245
approved these changes
May 10, 2024
Darkros1245
deleted the
142-app-device-overview-page-remove-device-button-not-sending-request-to-backend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed the invoke of deleting task and device to the server